Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the internal css file of epub #146

Open
TheDoom95 opened this issue Jan 8, 2025 · 4 comments
Open

Respect the internal css file of epub #146

TheDoom95 opened this issue Jan 8, 2025 · 4 comments
Assignees
Labels
🚀 Feature request New feature request or improvement

Comments

@TheDoom95
Copy link

Why you want this feature to be implemented? Please describe.

After discovering this reader, I realized that when I add an epub, the css file is not respected at all. It would be nice to add an option where the user wants to apply the css rules that are already declared in the epub, before the reader sets its own. The typography that comes in my epub is not reflected in the reader, some words that have already established an italic configuration are not respected either. Surely there are more professional books that implement bold, strikethrough ....

I base this on a light novel, where the layout designer has already set the parameters. It is an epub 3.0

PD: The typography is only used for the titles and this is hosted in fonts of the epub itself, as it is happening in my epub since it only has one. but there will be more epub with different fonts added or even surely imported through google fonts links.

Describe the feature you'd like to be implemented

In the reader settings section: Adding a check to enable the epub css to be used (if the reader supports it) enabled will skip the reader's css and disabled will use the reader's css.

Additional context

Typography (Only happens with the title as the rest of the text is the default)

WhatsApp Image 2025-01-08 at 1 14 24 AM

Italics

WhatsApp Image 2025-01-08 at 1 14 25 AM

Use sigil to show the structure of the xhtml. Here it is shown who owns the epub and the typography is in title mode.

Captura de pantalla (4)

@TheDoom95 TheDoom95 added the 🚀 Feature request New feature request or improvement label Jan 8, 2025
@Acclorite
Copy link
Owner

Acclorite commented Jan 8, 2025

Can you please provide a book file? While typography of the EPUB is not followed, italics should be shown correctly.
Edit: Oh it seems like a different typography when italics are applied

@TheDoom95
Copy link
Author

Sorry for the delay in answering. Here you have the url where you can download the volumes in epub if you are interested and I share directly the light novel I used as an example.

translator group with the volumes to download

Archive:
[RVN] Mushoku Tensei - Volumen 02 [SC] [CF].zip

¿Puedes proporcionarme un archivo del libro? Si bien no se respeta la tipografía del EPUB, la cursiva debería mostrarse correctamente. Editar: Oh, parece que se utiliza una tipografía diferente cuando se aplica la cursiva.

@TheDoom95
Copy link
Author

¿Puedes proporcionarme un archivo del libro? Si bien no se respeta la tipografía del EPUB, la cursiva debería mostrarse correctamente. Editar: Oh, parece que se utiliza una tipografía diferente cuando se aplica la cursiva.

Yes, use a different typography,
image

PD: Also. I don't know if I have to create another topic for this, but I focus on what my request is. It is if I have a preset configuration. that this is respected as far as possible. margins, padding, styles, fonts .... . if it is not respected because the reader works in a way. Then try to reproduce it. If not, apply the style that the reader has to make it work. I think the librera reader had an option to mix user style + reader styles? something like that. but if you see that it is not feasible the big part I am putting. I will understand.

@Acclorite
Copy link
Owner

Also. I don't know if I have to create another topic for this, but I focus on what my request is. It is if I have a preset configuration. that this is respected as far as possible. margins, padding, styles, fonts .... . if it is not respected because the reader works in a way. Then try to reproduce it. If not, apply the style that the reader has to make it work. I think the librera reader had an option to mix user style + reader styles? something like that. but if you see that it is not feasible the big part I am putting. I will understand.

Current Reader has nothing to do with CSS, so yes, it may be more like integrating styles from file's CSS into Reader. The most I can say, is that I may try to implement typography from file, but I already see difficulties. There are promising #23 and #52, I hope that it will make the possible implementation easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Feature request New feature request or improvement
Projects
None yet
Development

No branches or pull requests

2 participants