docs: add MPL2 license #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to c4c49ba in 7 seconds
More details
- Looked at
27lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. LICENSE:3
- Draft comment:
The copyright year should be updated to 2023 to reflect the current year. - Reason this comment was not posted:
Confidence changes required:50%
The license file is correctly formatted and includes all necessary components of the MIT License. However, the year should be updated to the current year, 2023, to reflect the correct copyright year.
Workflow ID: wflow_sTzlhQE1RD1bs5hG
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Thinking we might use MPL2.0 here, like the rest of ActivityWatch. |
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0238b6c in 32 seconds
More details
- Looked at
380lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. LICENSE.txt:1
- Draft comment:
The LICENSE.txt file contains the Mozilla Public License 2.0, but the PR description states that an MIT License should be added. Please update the file to include the correct MIT License text. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
According to the rules, we should not make assumptions based on the PR description or ask authors to update things based on it. The choice of license is a fundamental project decision that should be discussed elsewhere, not in code review comments. Additionally, this is a newly added file, so the author clearly intended to use MPL 2.0.
Maybe there was an actual requirement to use MIT license that I'm not aware of? The PR description could reflect important project requirements.
Even if there was such a requirement, a code review comment is not the right place to enforce it. This should be discussed in the PR description or separate communication channels.
Delete this comment as it violates the rule about not making assumptions based on PR descriptions and is not about a technical code issue.
Workflow ID: wflow_ZBu317BsJUgF3gjp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
@ErikBjare This is good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
LICENSE.txtwith Mozilla Public License Version 2.0 text.LICENSE.txtfile with Mozilla Public License Version 2.0 text, defining terms for use, modification, and distribution of the software.This description was created by
for 0238b6c. It will automatically update as commits are pushed.