Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a new version to npm #63

Open
denissb opened this issue Oct 9, 2018 · 3 comments
Open

Publish a new version to npm #63

denissb opened this issue Oct 9, 2018 · 3 comments

Comments

@denissb
Copy link

denissb commented Oct 9, 2018

The current version on npm is outdated and causes some problems with the latest build systems (webpack 3+), can we publish a new version with the latest changes?

@carcamano
Copy link
Contributor

Hi Denis.

Can you send me a PR with required changes?

Thanks

@denissb
Copy link
Author

denissb commented Oct 9, 2018

Sorry, my bad had incorrect version in package-lock.json. Closing.

@denissb denissb closed this as completed Oct 9, 2018
@denissb denissb reopened this Oct 12, 2018
@denissb
Copy link
Author

denissb commented Oct 12, 2018

No, the porblem is still there when building with @angular/cli, I get:
LicenseWebpackPlugin✖ 「wdm」: TypeError: licenseType.indexOf is not a function at LicenseTextReader.readLicense (/Users/id844903/proximus/web/magnolia-angular-usage-ng/node_modules/@angular-devkit/build-angular/node_modules/license-webpack-plugin/dist/LicenseTextReader.js:29:40) at PluginChunkReadHandler.processModule (/Users/id844903/proximus/web/magnolia-angular-usage-ng/node_modules/@angular-devkit/build-angular/node_modules/license-webpack-plugin/dist/PluginChunkReadHandler.js:52:62)

There is not code change required for this as I see in package.json the version is specified as a string (is an object in 1.0.12 on npm, which is deprecated). I think you just need to publish a new one with the changes since Apr 26, 2017. I am not the owner of the package so I can't do it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants