Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct type instability in fluxes computation #321

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

simone-silvestri
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (c6bffe7) to head (dfccf76).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Models/CrossRealmFluxes/atmosphere_ocean_fluxes.jl 0.00% 9 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #321   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         34      34           
  Lines       1983    1983           
=====================================
  Misses      1983    1983           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think causes an issue since it gets convertd in setindex but its a good idea anyways

@simone-silvestri simone-silvestri merged commit 048c893 into main Jan 5, 2025
20 checks passed
@simone-silvestri simone-silvestri deleted the ss/correct-ft-error branch January 5, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants