Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recover_profile declares type variable FT but does not use it. #108

Closed
simonbyrne opened this issue Aug 14, 2023 · 2 comments
Closed

recover_profile declares type variable FT but does not use it. #108

simonbyrne opened this issue Aug 14, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@simonbyrne
Copy link
Member

I get the following warning in Julia 1.9:

WARNING: method definition for recover_profile at /Users/simon/.julia/packages/SurfaceFluxes/wxPUw/src/SurfaceFluxes.jl:882 declares type variable FT but does not use it.

Linked method is here:

function recover_profile(
param_set::APS,
sc::AbstractSurfaceConditions,
L_MO,
Z,
X_in,
X_sfc,
transport,
uft::UF.AUFT,
scheme::Union{FVScheme, FDScheme},
) where {FT}
@assert isless.(Z, z_in(sc))
uf = UF.universal_func(uft, L_MO, SFP.uf_params(param_set))
von_karman_const::FT = SFP.von_karman_const(param_set)
_π_group = FT(UF.π_group(uf, transport))
_π_group⁻¹ = (1 / _π_group)
num1 = log(Z / z0(sc, transport))
num2 = -UF.psi(uf, Z / L_MO, transport)
num3 = UF.psi(uf, z0(sc, transport) / L_MO, transport)
Σnum = num1 + num2 + num3
ΔX = X_in - X_sfc
return Σnum * compute_physical_scale_coeff(param_set, sc, L_MO, transport, uft, scheme) * _π_group⁻¹ * ΔX + X_sfc
end

@akshaysridhar
Copy link
Member

akshaysridhar commented Aug 14, 2023

Cleaning up some of this in #82. Will reach out for review when ready.

@akshaysridhar akshaysridhar added the good first issue Good for newcomers label Aug 16, 2023
@akshaysridhar
Copy link
Member

@sriharshakandala I think we can close this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants