Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

year_sector_data is throwing warnings and year_sector_table errors #130

Open
maxwell8888 opened this issue Nov 8, 2017 · 0 comments
Open

year_sector_data is throwing warnings and year_sector_table errors #130

maxwell8888 opened this issue Nov 8, 2017 · 0 comments
Assignees
@maxwell8888

Comments

@maxwell8888
Copy link
Contributor

work through code and fix. add year_sector_data class initializing into GVA_by_sector whilst I am at it.
@maxwell8888 maxwell8888 self-assigned this Nov 8, 2017
maxwell8888 added a commit that referenced this issue Nov 9, 2017
@maxwell8888
fixing issue #130
85c2172 
the previous extract_gva_data function was also including total gva by
year rows. this has now been added to the new gva function. also moved
setting the year_sector_data class into the GVA_by_sector class so it is
tidyer and doesn't need to be run separately. still need to change it
from a list to dataframe and add checks.
mammykins added a commit that referenced this issue Nov 10, 2017
@mammykins
Merge pull request #132 from DCMSstats/fix/130
81263ec 
fixing issue #130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxwell8888 maxwell8888

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maxwell8888