Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

float input Deprecated for math.factorial #1

Open
jasonfan1997 opened this issue Apr 17, 2023 · 1 comment
Open

float input Deprecated for math.factorial #1

jasonfan1997 opened this issue Apr 17, 2023 · 1 comment

Comments

@jasonfan1997
Copy link

Hi @ElimThompsonFDA , I tried running the example script on my python environment and https://github.com/DIDSR/QuCAD/blob/main/scripts/tools/calculator.py#L137 threw me a type error.

From, https://docs.python.org/3/library/math.html#math.factorial

It seems math.factorial float input support is deprecated in Python 3.9 and above. I think the easiest way to handle it is to change all math.factorial to numpy.math.factorial since numpy is required and imported here anyway.

@ElimThompsonFDA
Copy link
Collaborator

Pushed the change for scripts/tools/calculator.py.
Thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants