Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default of DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES to true for 3.0 #4858

Closed
cowtowncoder opened this issue Dec 18, 2024 · 4 comments
Closed

Change default of DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES to true for 3.0 #4858

cowtowncoder opened this issue Dec 18, 2024 · 4 comments
Labels
3.0 Issue planned for initial 3.0 release

Comments

@cowtowncoder
Copy link
Member

Describe your Issue

As of Jackson 2.x, DeserializationFeature. FAIL_ON_NULL_FOR_PRIMITIVES defaults to false, allowing coercion from JSON null into Java int, long and so on.
For some users -- and especially on "low null" languages like Kotlin -- such coercion is rarely expected, so suggestion was made to change the default.

No decision is yet made: discussion for helping decision is here:

FasterXML/jackson-future-ideas#79

this issue is placeholder until decision is made.
@cowtowncoder cowtowncoder added to-evaluate Issue that has been received but not yet evaluated 3.0 Issue planned for initial 3.0 release and removed to-evaluate Issue that has been received but not yet evaluated labels Dec 18, 2024
@cowtowncoder cowtowncoder mentioned this issue Dec 18, 2024
Open
@yawkat
Copy link
Member

yawkat commented Dec 30, 2024

I assume title should say "change to true"?

Sounds like a good change to me.

@cowtowncoder cowtowncoder changed the title Change default of DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES to false for 3.0 Change default of DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES to true for 3.0 Dec 31, 2024
@cowtowncoder
Copy link
Member Author

@yawkat Thanks, yes fixed that typo. And looks like proposal is passing (5 to 1 voting as of now).

@cowtowncoder
Copy link
Member Author

As per FasterXML/jackson-future-ideas#79, proposal approved, will work on this.

cowtowncoder added a commit that referenced this issue Jan 7, 2025
@cowtowncoder
Fix #4858: change default for `DeserializationFeature.FAIL_ON_NULL_FO…
4f6aec4 
…R_PRIMITIVES` to true
cowtowncoder added a commit that referenced this issue Jan 7, 2025
@cowtowncoder
Fix #4858: change default for `DeserializationFeature.FAIL_ON_NULL_FO…
b63eb33 
…R_PRIMITIVES` to true (#4884)
@JooHyukKim
Copy link
Member

JooHyukKim commented Jan 8, 2025 •
edited
Loading

Added PR to push through changes in #4890.
Modified JSTEP-2 accordingly.

cowtowncoder pushed a commit that referenced this issue Jan 9, 2025
@JooHyukKim
(complete #4858): actually change default `FAIL_ON_NULL_FOR_PRIMITIVE…
a77efa2 
…S` to `true` (#4890)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.0 Issue planned for initial 3.0 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cowtowncoder @yawkat @JooHyukKim