Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lineplot syntax in activations.jl docs to work with new UnicodePlots.jl #623

Open
zengmao opened this issue Jan 8, 2025 · 1 comment

Comments

@zengmao
Copy link

zengmao commented Jan 8, 2025

UnicodePlots.jl version 3.5 (April 2023) changed the lineplot syntax. See the changelog:
https://github.com/JuliaPlots/UnicodePlots.jl/blob/main/CHANGELOG.md

Now the syntax is lineplot(-1, 1, x->x^2) instead of lineplot(x->x^2, -1, 1). The function plots in activations.jl doc strings still uses the old syntax.

@mcabbott
Copy link
Member

mcabbott commented Jan 8, 2025

Oh no, that's weird? Functions first is near-universal, to allow do blocks. Seems to be here, no discussion & not marked as breaking: JuliaPlots/UnicodePlots.jl#343

Anyway we couldn't get these to work as doctests, so at least nothing broke here! We can change them all if someone wants to. Thanks for the note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants