Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run js minifier on <script> content in html minifier #5

Open
GuillaumeGomez opened this issue Apr 17, 2017 · 5 comments
Open

Run js minifier on <script> content in html minifier #5

GuillaumeGomez opened this issue Apr 17, 2017 · 5 comments

Comments

@GuillaumeGomez
Copy link
Owner

No description provided.

@frewsxcv
Copy link

I don't think you can assume that everything inside <script> is JavaScript

@GuillaumeGomez
Copy link
Owner Author

Only on type=text/javascript I suppose. The same goes for <style>.

@frewsxcv
Copy link

I don't think you can make any assumptions about the body of <script> or <style>. Even if I do <script type='text/javascript'> one can still put invalid JavaScript in there

@GuillaumeGomez
Copy link
Owner Author

Hum, I guess. Would be great though...

@frewsxcv
Copy link

frewsxcv commented Apr 24, 2017 •
edited
Loading

In general, I suggest copying what other minifiers are doing instead of making up what you think works. I also suggest copying their test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frewsxcv @GuillaumeGomez