Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ncbi_taxon_id from biomaterial_core to donor_organism #1415

Open
hannes-ucsc opened this issue Sep 14, 2021 · 0 comments
Open

Move ncbi_taxon_id from biomaterial_core to donor_organism #1415

hannes-ucsc opened this issue Sep 14, 2021 · 0 comments

Comments

@hannes-ucsc
Copy link
Contributor

biomaterial_core.ncbi_taxon_id refers to a species.

Biologically speaking, only donor organisms can be of a species and all biomaterials must have been derived from a donor organism at some point. Therefore, all biomaterials have an implicit species: the same species as that of the donor they are derived from. Defining ncbi_taxon_id in biomaterial_core allows for anomalous metadata graphs where a biomaterial and the donor it was derived from have contradicting NCBI taxon IDs. The schema should be modeled such that it does not allow for anomalous graphs.

Moving ncbi_taxon_id from biomaterial_core to donor_organism would eliminate the possibility of these anomalous graphs. It would require that every graph contains at least one donor and that every biomaterial in that graph is directly or indirectly connected to a donor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant