-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nelson-Siegel and Smoothing Spline Yield Curve fitting #70
Comments
Would like to contribute to this issue. Please advise next steps. Thanks! |
A good first step would be to make a struct that holds the data for the Nelson-Siegel parametrisation and methods for computing discount and zero rate correctly. Add in some tests. You can get inspired by the Smith-Wilson implementation. The open a draft pr. |
Tried to implement and added NelsonSiegelSvensson.jl and SmoothingSplines.jl whose approach might be debatable but please advise how these can be uploaded/pulled for a review. |
Awesome! Check out this article about creating a pull request: https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github A PR will allow the automated tests/checks to occur and makes it easy to review the changes. |
Two of three will be completed in #116 |
I have seen there are two spline methods in bootstrapping, do we still need smoothing splines? In this reference https://www.bis.org/publ/bppdf/bispap25.pdf it seems to talk about cubic splines, so smoothing splines here would mean cubic splines, or splines with even higher degrees? Thanks.
|
My understanding is that "smoothing splines" refers to fitting (minimizing error) of a starting spline model, whereas the existing methods fit simple splines through bootstrapped points (for the given points, the model error is zero). |
I was looking at DataInterpolations.jl and think that maybe it has smoothing spline fitting built in? |
I think you are right, and there are examples showing how to call the BSpline functions. https://htmlpreview.github.io/?https://github.com/PumasAI/DataInterpolations.jl/blob/v2.0.0/example/DataInterpolations.html. |
Seems like a good reference:
Three related variants:
This could be good first issue for someone familiar with the above methods already.
The text was updated successfully, but these errors were encountered: