Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs build #31

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix docs build #31

wants to merge 6 commits into from

Conversation

JonasKoziorek
Copy link
Contributor

One of the algorithms stopped converging for examples in the docs. I changed the initial guesses and precision. This must have resulted from some changes in other libraries, probably NonlinearSolve.

@JonasKoziorek
Copy link
Contributor Author

Strange, I pass the tests locally.

@Datseris
Copy link
Member

Datseris commented Jan 2, 2025

Any way you can fix the tests? change tolerances or something? Docs wont build if tests fail.

Thanks for the PR!

@JonasKoziorek
Copy link
Contributor Author

I will play around with parameters and see if it passes the tests.

@JonasKoziorek
Copy link
Contributor Author

Any tips on how to debug why the tests run locally and not here?

@Datseris
Copy link
Member

Datseris commented Jan 8, 2025

Can you tell me what is going wrong with the test? What is it supposed to be testing and what it finds instead?

@JonasKoziorek
Copy link
Contributor Author

res = periodic_orbits(ds, alg, igs)
@test length(res) == 2

Given two initial guesses, the algorithm finds an orbit only for one of the guesses.
Maybe after the update of NonlinearSolve the SciML solver doesn't converge to the same result for the given initial guess. (11063cb#diff-72ed386c2a0cd1d23c0968297e70023ed98c22490d146dd89fc91f48369bad4dL18)

@Datseris
Copy link
Member

Datseris commented Jan 9, 2025

Can you just check out the branch, run the initial conditions and see if you get the orbit you should, otherwise change the guess?

@Datseris
Copy link
Member

Datseris commented Jan 9, 2025

Or, significantly increase the starting guess period for the second orbit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants