Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deep links for electron #3622

Open
jessfraz opened this issue Aug 22, 2024 · 3 comments · May be fixed by #4166
Open

deep links for electron #3622

jessfraz opened this issue Aug 22, 2024 · 3 comments · May be fixed by #4166
Labels
desktop-app Issues from the desktop app. enhancement New feature or request

Comments

@jessfraz
Copy link
Contributor

this can wait for after initial merge we need for v1 to open text-to-cad in modeling-app from the website

https://www.electronjs.org/docs/latest/tutorial/launch-app-from-url-in-another-app

@jessfraz jessfraz added enhancement New feature or request desktop-app Issues from the desktop app. labels Aug 22, 2024
@jessfraz jessfraz added this to the v1 Modeling App Launch milestone Aug 22, 2024
@jessfraz
Copy link
Contributor Author

@jessfraz
Copy link
Contributor Author

Okay this works, we just need a route for sending raw kcl code that does the following:

zoo-studio://some-path-we-define?code={kcl-code}&filename={optional kcl file name user can override in app}

  • promnpt user if they want to add to existing project or create new
  • prompt user for the name of the file, where in the url query args maybe we can pass a default file name
  • then open the file

@franknoirot
Copy link
Collaborator

So sick.

  1. Within Home.tsx we can use the useSearchParams hook to get whatever query params we want off the URL.
  2. We can wire up a new command to the Home machine for this "create or add to project" logic, using your outline above
  3. We can watch for the presence of a certain query param to fire off the command palette's "Find and select command" event for that new command, with the rest payload passed along to the command.

@jessfraz jessfraz linked a pull request Jan 5, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop-app Issues from the desktop app. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants