Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Shell point and click references the wrong feature #4961

Open
nicboone8 opened this issue Jan 7, 2025 · 8 comments
Open

[BUG] Shell point and click references the wrong feature #4961

nicboone8 opened this issue Jan 7, 2025 · 8 comments
Assignees
Labels
bug Something isn't working coredump Issues that contain a coredump. desktop-app Issues from the desktop app.

Comments

@nicboone8
Copy link

I think this might be an easy fix- the output from the shell button just needs to reference the selected feature instead of the default one.
Also I can't select multiple faces when creating a shell

Zoo.Modeling.App.2025-01-07.10-30-48.mp4

Note: If you are capturing from a browser there is limited support for screenshots, only captures the modeling scene.
If you are on MacOS native screenshots may be disabled by default. To enable native screenshots add Zoo Modeling App to System Settings -> Screen & SystemAudio Recording for native screenshots.

Core Dump

coredump-af3cd7bd-54c3-492f-9236-9e4bdebf455a.json

Reference ID: af3cd7bd-54c3-492f-9236-9e4bdebf455a

KCL Code
sketch001 = startSketchOn('XY')
  |> startProfileAt([6.77, 0], %)
  |> yLine(1.27, %)
  |> tangentialArcTo([5.96, 2.37], %)
  |> tangentialArcTo([-6.2, 2.44], %)
  |> tangentialArcTo([-6.6, 1.82], %)
  |> yLine(-1.82, %)
  |> close(%)
  // |> mirror2d({ axis = "X" }, %)
  |> extrude(10, %)

sketch002 = startSketchOn(sketch001, 'END')
  |> circle({ center = [-0.01, 1.58], radius = 1.2 }, %)
  |> extrude(1.2, %)

// shell({ faces = ['end'], thickness = .1 }, [sketch002])

shell001 = shell({ faces = ['end'], thickness = .1 }, sketch001)

@nicboone8 nicboone8 added bug Something isn't working coredump Issues that contain a coredump. desktop-app Issues from the desktop app. labels Jan 7, 2025
@pierremtb pierremtb self-assigned this Jan 8, 2025
@pierremtb
Copy link
Collaborator

Hey @nicboone8 thanks for the report I can look into that.

For your second note on multiple faces, can you elaborate? It should support 'cap' and 'wall' type of faces. We still have #4775 open that should better catch selection issues once merged (right now the flow can silently fail).

Image Image

@nicboone8
Copy link
Author

Thanks @pierremtb!

Selecting multiple faces is working perfectly for me now. I'll keep trying to replicate what I was seeing yesterday. Basically every time I selected a second face, the first face would de-select

@pierremtb
Copy link
Collaborator

@nicboone8 Any chance you're pressing shift today but weren't yesterday?

@nicboone8
Copy link
Author

That's always possible 😝. I thought it might be because I was working on a more complex part, but maybe I only tried CTRL and ALT but not shift

@nicboone8
Copy link
Author

Here's something interesting. I can select multiple faces without using any keyboard buttons when the part includes a 2d mirror

Zoo.Modeling.App.2025-01-08.14-21-21.mp4

@pierremtb
Copy link
Collaborator

@nicboone8 Oh that's a great find. Can confirm that with mirror2d present the selection becomes 'sticky' without any key pressed. In and out of the Shell command too

@pierremtb
Copy link
Collaborator

pierremtb commented Jan 8, 2025

I believe this happens in the case of an artifact graph not fully populated on the frontend. In this case the engine returns an id on select that we can't map to anything in the artifact graph. It's the same for lofts today on main, before #4898 is merged. But that PR is loft specific w.r.t the artifact graph build up

@pierremtb
Copy link
Collaborator

@nicboone8 Ok I can reproduce your first issue: happens only when extrude is in the sketch pipe, not when it's broken out as a variable. See below.

Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coredump Issues that contain a coredump. desktop-app Issues from the desktop app.
Projects
None yet
Development

No branches or pull requests

2 participants