Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace closures with passing explicit parameters #156

Open
JordiBolibar opened this issue Jul 10, 2024 · 0 comments
Open

Replace closures with passing explicit parameters #156

JordiBolibar opened this issue Jul 10, 2024 · 0 comments
Labels
enhancement New feature or request performance Improve code performance

Comments

@JordiBolibar
Copy link
Member

In order to avoid performance issues and problems with AD, we should stop using closures in the model. This should be as easy as passing the whole simulation struct, which should have everything needed, including the theta parameters to be optimized.

@JordiBolibar JordiBolibar added enhancement New feature or request performance Improve code performance labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Improve code performance
Projects
None yet
Development

No branches or pull requests

1 participant