Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogglyHandler - incorrect records comparison. #1838

Closed
dimasvas opened this issue Sep 20, 2023 · 2 comments · Fixed by #1841
Closed

LogglyHandler - incorrect records comparison. #1838

dimasvas opened this issue Sep 20, 2023 · 2 comments · Fixed by #1841
Labels
Milestone

Comments

@dimasvas
Copy link

dimasvas commented Sep 20, 2023

Monolog version 3.4.0

Loggly does not receive all logs. The reason is an incorrect records comparison in LogglyHandler.

Source reference

Now the code is:

return ($record->level >= $level);

It looks like should be:

return ($record->level->value >= $level->value);

We should compare values properties of records.

@dimasvas dimasvas added the Bug label Sep 20, 2023
@omerimzali
Copy link
Contributor

Hi @dimasvas, I crated a pr for this one.
#1841

@dimasvas
Copy link
Author

dimasvas commented Oct 2, 2023

Hi omerimzali! Thank you very much!!!!
I have just decorated the handler and created a temporary kludge until a new version of the monolog package with the fix will be released. Thank you again! Looking forward for new monolog fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants