Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming inconsistency between scopes and optional_scopes #5032

Open
kinngh opened this issue Dec 4, 2024 · 2 comments
Open

Naming inconsistency between scopes and optional_scopes #5032

kinngh opened this issue Dec 4, 2024 · 2 comments
Labels
Area: @shopify/app @shopify/app package issues #gsd:39564

Comments

@kinngh
Copy link

kinngh commented Dec 4, 2024

The newly announced Optional Access Scopes works absolutely beautifully, especially paired with App Bridge CDN. I have one minor annoyance with it, which is inconsistency in types in shopify.app.toml.

scopes="read_content,write_content" 
optional_scopes=["read_products", "read_orders"]
  • scopes is a string, separated by commas
  • optional_scopes is an array of strings

This is also reflected in the changelog under Declaring optional scopes and official docs under Managed access scopes > Scopes

@graygilmore graygilmore added the Area: @shopify/app @shopify/app package issues label Dec 6, 2024
@isaacroldan
Copy link
Contributor

Thanks for the feedback @kinngh , i'll pass it to the responsible team

@kbav
Copy link

kbav commented Dec 16, 2024

Hello @kinngh!

The scopes & optional_scopes types inconsistency is something that we are aware of, and are investigating all of the necessary details for rectifying seamlessly.

We greatly appreciate this critique. Thank you also for your kind words regarding optional scopes & App Bridge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/app @shopify/app package issues #gsd:39564
Projects
None yet
Development

No branches or pull requests

4 participants