Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metafield theme-check #575

Open
3 tasks
aswamy opened this issue Nov 7, 2024 · 0 comments
Open
3 tasks

Metafield theme-check #575

aswamy opened this issue Nov 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@aswamy
Copy link
Contributor

aswamy commented Nov 7, 2024

Is your feature request related to a problem? Please describe.

Follows up #502
We need to verify if metafields being used in the code are valid. If the metafield does not exist, you should see a warning when running shopify theme check

Describe the solution you'd like

For themes:

  • running shopify theme check should verify if the metafield exists on your shop
  • If you don't have the metafield, you should get a warning message

For theme app extensions:

Tasks

  • Update theme-check in theme-tools to error out when metafield definitions dont exist
  • Add lint ignore rules in Dawn + Horizon where we use metafields that don't exist in any shops by default
  • Update CLI so there is a warning when running theme check and metafield isnt defined

NOTE: There are a few differences when you pull metafield definitions from CLI or from Theme Access App via CLI

@aswamy aswamy added the enhancement New feature or request label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant