Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd Party Bundle Support #127

Open
askpatrickw opened this issue Sep 8, 2021 · 3 comments
Open

3rd Party Bundle Support #127

askpatrickw opened this issue Sep 8, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@askpatrickw
Copy link
Contributor

Today (2021-09-08) Circup can download and install libraries from three bundles:

  • Adafruit CircuitPython Bundle
  • Community Bundle
  • CircuitPython.org Bundle

This issue\discussion is about how to support 3rd party bundles which follow the CP library bundling format. This conversation originally started in a PR to move the references to the bundles from within the code to an JSON configuration file. (#126)

Proposals at that time included:

User Supplied Config.json

In addition to the config.json released with circup, look for a config file in AppDirs so that you can look for the config json file first in the user's configuration directory and then to the default list shipped in the package. If a config.json existed in AppDirs, those bundles would be merged with the bundles released with Circup.

Circup Bundle Management Commands

Add Bundle Management Commands to Circup for Add, Remove, Reorder, display Info for bundles. This would update the configuration JSON.

I think that summarizes things.. I'll add my own comments\thoughts seperately

@askpatrickw
Copy link
Contributor Author

I actually don't have any big thoughts about this right now. I think the file in AppDirs is a good plumbing step and then the commands could be added separately.

Are there any third party library bundles today?
It might also be a useful mechanism for testing.

@askpatrickw askpatrickw added the enhancement New feature or request label Sep 8, 2021
@Neradoc
Copy link
Contributor

Neradoc commented Sep 8, 2021

I've been testing https://github.com/Neradoc/Circuitpython_Keyboard_Layouts locally with an implementation of bundle commands, I'll look into reworking it to use bundle_config.json.

@jepler
Copy link
Member

jepler commented Sep 12, 2022

Did this get implemented or is there something left to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants