Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to remove build-in bundle (to bypass infra issue) #187

Open
dglaude opened this issue Oct 31, 2023 · 3 comments
Open

Fail to remove build-in bundle (to bypass infra issue) #187

dglaude opened this issue Oct 31, 2023 · 3 comments

Comments

@dglaude
Copy link

dglaude commented Oct 31, 2023

On Windows 10, with Python 3.10.11, I try to use circup to migrate to CP 9.0.

To avoid errors, I wanted to remove a bundle, but I cannot remove it.

Not sure if that is normal.

C:\Project>python --version
Python 3.10.11

C:\Project>circup --version
CircUp, A CircuitPython module updater. Version 1.4.0

C:\Project>circup bundle-show
Downloading latest bundles for circuitpython/CircuitPython_Org_Bundle (20231029).
py:
There was a problem downloading that platform bundle. Skipping and using existing download if available.
adafruit/Adafruit_CircuitPython_Bundle
    https://github.com/adafruit/Adafruit_CircuitPython_Bundle
    version = 20231031
adafruit/CircuitPython_Community_Bundle
    https://github.com/adafruit/CircuitPython_Community_Bundle
    version = 20231030
circuitpython/CircuitPython_Org_Bundle
    https://github.com/circuitpython/CircuitPython_Org_Bundle
    version = 0.0.3

C:\Project>circup bundle-remove circuitpython/CircuitPython_Org_Bundle
Cannot remove built-in module:
    circuitpython/CircuitPython_Org_Bundle
@FoamyGuy
Copy link
Contributor

My understanding was that bundle-remove is intended to be used with local bundles which are ones that were added with bundle-add command.

I can see rationale behind removing the one that is currently emitting warnings. But I worry that altering circup to allow removing the built-in "real" bundles instead of only local ones could wind up with people who have accidentally removed the main bundle and then subsequently cannot get circup to work any more.

If we do want to allow the removal of the built-in "real" bundles I think we'd also need to add a command to add them back in since the existing bundle-add command is expecting to be used with local bundles, not the ones that it downloads.

@dhalbert
Copy link
Contributor

Maybe we should change Cannot remove built-in module: to Not allowed to remove built-in module or Removing built-in module not permitted.

@dglaude
Copy link
Author

dglaude commented Oct 31, 2023

Maybe add a circup bundle-restore to bring back the default in case someone want to repair.
And the message can be: You are removing a default bundle, you can use "bundle-restore" if you change your mind or that was a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants