Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No colours in notifier #53

Open
iainbeeston opened this issue Nov 7, 2014 · 1 comment
Open

No colours in notifier #53

iainbeeston opened this issue Nov 7, 2014 · 1 comment

Comments

@iainbeeston
Copy link
Contributor

I use kicker with the terminal-notifier gem, so that when each test run completes I get a native OS X notification of the result. Unfortunately, the notification text includes special characters for colouring the test output:

screen shot 2014-11-07 at 15 58 50

I'm not sure if this applies equally to all notifier gems, but should special characters like these be stripped before being sent to the notifier?

@Manfred
Copy link
Collaborator

Manfred commented Nov 7, 2014

Yes, it should be stripped before it's being passed to the notifier. I think this is the place where it should happen:

https://github.com/alloy/kicker/blob/master/lib/kicker/job.rb#L49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants