-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Statically linking arrayfire #192
Comments
There is one major problem with doing that I think. Rust crates can't go beyond a certain size. ArrayFire binaries are big right now, definitely not in the range of crate size, the last time I checked it was 10MB |
Whether you use static or dynamic binaries of ArrayFire, the size can't go to 10MB for sure. |
Looks like per crate limits were added but I don't know yet if it's released. |
Also, I am not really sure if it's good idea to club binary along with crate using static linking. Because right now there is an advantage : user can install/modify ArrayFire installation independent of crate version and as long as crate <major.minor> version matches ArrayFire's <major.minor> version, it is ready for use. |
A feature could be added to enable dynamic linking as well. By default it could be statically linked, but for deployment it could then be dynamically linked by enabling the feature. |
@vadixidav I have no experience doing such packaging(involving static linking but handling all OSes) in rust crates. Can you please point to another crate that does this. |
@9prady9 Sure, I actually just did this for the Rust flann bindings here. Check the |
I am concerned by build times of ArrayFire - it takes too much time to be honest. Let me check flann-sys. Sure, give it a try and feel free to contact on slack for quick response if you face problems during static build. |
@umar456 Can you please share your findings w.r.t creating a static library of ArrayFire here. |
@vadixidav Did you get the chance to try it out ? |
I haven't, but I can give it a try when I get a chance. |
Right now arrayfire has to be used by linking to the DLL. Since the only parts of arrayfire that are included in the Rust bindings are BSD 3-clause, there should be no problem statically linking arrayfire. Is it possible that we could choose whether or not arrayfire is statically linked to ease distribution? Also, is there any downside to just always statically linking arrayfire? I feel like that would be more in-line with what the Rust community expects: adding a crate to your
Cargo.toml
should "just work".The text was updated successfully, but these errors were encountered: