Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditions on Pfmp validation #1259

Open
pskl opened this issue Dec 3, 2024 · 0 comments
Open

Add conditions on Pfmp validation #1259

pskl opened this issue Dec 3, 2024 · 0 comments

Comments

@pskl
Copy link
Collaborator

pskl commented Dec 3, 2024

We already added two new checks on Pfmp Validation recently (DA + Rib)

Lets go further and add those as well:

def self.asp_ready
    with_ine
      .with_biological_sex
      .with_valid_birthplace
      .with_valid_address
  end

We keep the checks in the validator as an extra security measure but blocking at validation level would streamline the process for everyone

-> Introduce a new method on Student called #asp_ready? that checks for the presence of all the necessary attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant