Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve license checker to work only on certain files #3715

Open
tiborsimko opened this issue Jan 6, 2025 · 0 comments
Open

ci: improve license checker to work only on certain files #3715

tiborsimko opened this issue Jan 6, 2025 · 0 comments

Comments

@tiborsimko
Copy link
Member

Current behaviour

The license checker by default checks all the fixture files during its execution and the CI run. This is perfectly fine, since it is rather fast (about 2 seconds).

However, if we enrich the metadata checker script in order to check other fields as well -- see #3714 -- then it may become worth improving the script so that it could operate only on certain desired files.

Possible improvements

  • Instead of working over all the JSON files, the script could take CLI arguments of file paths, and perform checks only on those.

  • When the script is run in the CI for a pull request, the script could detect which files have been changed in the pull request over the base branch, and perform checks only on those modified files.

  • Ditto locally, if I'm on a certain branch, make a git diff master --numstat and run the controlled vocabulary checks only on the added or modified files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant