-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not work under Node 0.11.x and 0.12.x #87
Comments
Seems to be an issue when running node 0.11.x. |
Looks like most of the unit tests fails under Node 0.11.x with similar symtom (child nodes missing or truncated). Primary suspect is HTML parser or DOM implementation modules because html2jade outputs what it sees. |
any updates on this |
just tried with same result which is not surprising since do have to run html2jade under node 0.11.x? |
I am trying to use this in latest chrome which I suppose has the latest node |
sorry but chrome, the browser, does not have node.js inside of it. |
with atom it does |
Yes, Atom uses both Chrome and Node.js. |
TO THOSE WHO ABSOLUTELY NEED TO RUN HTML2JADE UNDER 0.11: Try forking and replacing |
How about then switching away from |
Cheerio is definitely an option since |
Working in a PR. if module?
isNode = true |
Ah, yes, three AFAIK: bower, browserify, scalate. there might be other browser use-cases that could break. BTW, let me know if you'd like to be added as a collaborator. This project needs someone would could give it more TLC. |
Sorry for the silence. Given the above requirements, it would seem that Cheerio is not the way to go then. |
yeah. that was my conclusion last time I looked at Cheerio. |
For anybody who want to run it on 0.11 or 0.12, you can use my fork for the time being. I just changed "dependencies": {
"html2jade": "Nedomas/html2jade"
} |
Verified that html2jade works with Node.js v4. |
When supplying a file that has a DIV as the outer most element I only get the DIV in the jade file and not any of it's children.
The text was updated successfully, but these errors were encountered: