Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: improve the OSV scanner to reduce the maintenance burden #4945

Open
zhaohuabing opened this issue Dec 18, 2024 · 2 comments
Open

CI: improve the OSV scanner to reduce the maintenance burden #4945

zhaohuabing opened this issue Dec 18, 2024 · 2 comments
Labels
area/ci CI and build related issues help wanted Extra attention is needed

Comments

@zhaohuabing
Copy link
Member

  • Recursive scan is only done for vulnerabilities scan. For license scan only root go.mod is scanned since we don't care about licenses of dev packages.
    I wonder if we also need recursive vulnerabilities scan. I added it back then to prevent supply chain attacks, but on the other the scan also fails because of CVEs like this one which is only relevant for packages that are compiled with the released binary, not for packages used in dev / CI/CD.

  • Regarding the maintenance effort - we can omit the version field in PackageOverrides sections with the risk of package relicensing on version upgrade.
    package relicensing can occur both on minor release(i.e. terraform) or major release(i.e. grafana).
    Currently call analysis doesn't work so there are many false positives in vulnerability scan since we use a newer go version than the one installed in osv-scanner-action image. One of osv-scanner maintainers [GitHub Action] Call analysis doesn't work for go projects with go version > 1.22.8 google/osv-scanner#1453 (comment) that it's a good idea to support running osv-scanner on host, thus allowing the consumer to pre-install its desired go version. Once it's supported we will have no false positives which will make the maintenance easier.

originally posted by @shahar-h on #4941 (comment)

@zhaohuabing zhaohuabing added triage area/ci CI and build related issues help wanted Extra attention is needed and removed triage labels Dec 18, 2024
@zhaohuabing
Copy link
Member Author

@shahar-h Let's continue the discussion here.

@shahar-h
Copy link
Contributor

See google/deps.dev#147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI and build related issues help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants