Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with v1.32.3 Release: References Non-Existent v0.13.4 Version #1080

Open
kyoh86 opened this issue Jan 6, 2025 · 3 comments
Open

Issue with v1.32.3 Release: References Non-Existent v0.13.4 Version #1080

kyoh86 opened this issue Jan 6, 2025 · 3 comments

Comments

@kyoh86
Copy link

kyoh86 commented Jan 6, 2025

The 1.32.3 release of the go-control-plane/envoy package references a non-existent v0.13.4 version of the go-control-plane package, causing errors during go get -u ./....

Steps to reproduce:

  1. Run go get -u ./... in a module that indirectly depends on go-control-plane/envoy.
  2. Observe the error:
go: downloading github.com/envoyproxy/go-control-plane/envoy v1.32.3
go: downloading github.com/envoyproxy/go-control-plane v0.13.4
go: upgraded github.com/envoyproxy/go-control-plane v0.13.1 => v0.13.4: error finding sum for github.com/envoyproxy/[email protected]: reading github.com/envoyproxy/go-control-plane/go.mod at revision v0.13.4: unknown revision v0.13.4

The erroneous version is still available at pkg.go.dev.

This issue needs to be addressed to avoid breaking builds.

@mathieu-lemay
Copy link

It's probably related to #1074

Seriously, the number of issues related to the package split is crazy. Anyway, in the meantime, this worked for me to work around the issue

go mod edit -exclude=github.com/envoyproxy/go-control-plane/[email protected]

@valerian-roche
Copy link
Contributor

Hey, I managed to release the version (confusion on access led to a partially delivered revision).
From quick testing I do not see issues anymore when running go get -u from a repo importing cloud.google.com/go/storage, which makes me believe this issue (and #1074) have been addressed, but it's also hard to know if actually the case in user setup.

Can you confirm if this issue is addressed from your point-of-view and import chain?
Sorry for the confusion and impact

PS: on the comment on issues on split. There is no clean way to split sadly as far as I can understand (as the recommended way requires publishing a release that won't compile - as can't be reflected in go.sum, and therefore cannot be cleanly merged). Hopefully those issues can lead to further improvements of the process

@kyoh86
Copy link
Author

kyoh86 commented Jan 7, 2025

This problem seems to be resolved for me, the dependency on go-control-plane is now v1.32.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants