Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Dead code found by static analyzer? #289

Open
QiAnXinCodeSafe opened this issue Jul 18, 2018 · 1 comment
Open

Dead code found by static analyzer? #289

QiAnXinCodeSafe opened this issue Jul 18, 2018 · 1 comment

Comments

@QiAnXinCodeSafe
Copy link

Hi all,
This is Qihoo360 CodeSafe Team, we found some dead code issues in xcbuild, see
https://github.com/facebook/xcbuild/blob/7787fa91cad6b3d9fa73d4293b4a31e5b59067e9/Libraries/acdriver/Sources/Compile/Convert.cpp#L78. The line 81 and 84 are also dead code.

Can you guys help me to confirm this?

Thanks!

@sas
Copy link
Contributor

sas commented Jul 18, 2018

Yeah, a break after a return is dead code indeed...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants