Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate use-foo style feature flags in favor of just foo #1284

Open
michaelkirk opened this issue Dec 19, 2024 · 4 comments
Open

deprecate use-foo style feature flags in favor of just foo #1284

michaelkirk opened this issue Dec 19, 2024 · 4 comments

Comments

@michaelkirk
Copy link
Member

Rust 1.60 introduced the dep:foo syntax, which removed the ambiguity between a feature name and an optional crate name, so we no longer need the use- prefix.

Let's change it and deprecate the old ones.

@michaelkirk
Copy link
Member Author

michaelkirk commented Jan 8, 2025

I don't know that there's actually any good way of showing a deprecation warning when building with a deprecated feature flag. Anyone know any tricks?

rust-lang/cargo#7130
rust-lang/rfcs#3486

@lnicola
Copy link
Member

lnicola commented Jan 8, 2025

Mark Geometry and friends as deprecated when the feature flags are set 😅.

@michaelkirk
Copy link
Member Author

You brute! But that might work... 😄

@urschrei
Copy link
Member

urschrei commented Jan 8, 2025

That's incredibly horrible and I love it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants