Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboards): Allow sorting Dashboards table by release #82943

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

gggritso
Copy link
Member

@gggritso gggritso commented Jan 6, 2025

Closes #82925. Somewhere along the line, the logic that sorts data by release on the frontend (due to backend dataset limitation) broke. If someone created a widget, sorted by release, and saved it, it works. But, when someone is switching to sorting by release the preview is busted because we forgot to fetch releases for them.

This PR makes sure that if they update widget settings to start sorting by release, we fetch the releases.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Bundle Report

Changes will increase total bundle size by 10.31kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 32.2MB 10.31kB (0.03%) ⬆️

@gggritso gggritso requested a review from narsaynorath January 6, 2025 19:58
@gggritso gggritso marked this pull request as ready for review January 6, 2025 19:58
@gggritso gggritso requested a review from a team as a code owner January 6, 2025 19:58
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for now since we're required to do the sorting in the frontend

@gggritso gggritso merged commit 356f06a into master Jan 8, 2025
42 checks passed
@gggritso gggritso deleted the fix/dashboards/sort-by-release-name-in-table branch January 8, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot sort Dashboards table by release
2 participants