Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production logs shouldn't have shell codes in them #90

Closed
markstory opened this issue Dec 11, 2024 · 3 comments
Closed

Production logs shouldn't have shell codes in them #90

markstory opened this issue Dec 11, 2024 · 3 comments

Comments

@markstory
Copy link
Member

While colourized logs are nice for local development, in production we should disable colourization of logs as it make logging harder to read.

@markstory
Copy link
Member Author

We already have non-colorized logging setup. By setting log_format: json in the config file or TASKBROKER_LOG_FORMAT=json as an environment variable.

@john-z-yang
Copy link
Member

@markstory

Are there any further actions required for this task? I didn't read the comment and I created a pr to add an option to disable ANSI encoding (which is those shell code), but I'm not sure if that's necessary given we already have log_format: json.

#109

I think we should either merge this PR or close this issue. Personally I don't see the use of disabling ANSI given we have log_format: json, but I'm happy with either!

@markstory
Copy link
Member Author

I don't think there is anything else we need to do. The existing json formatting will cover our needs in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants