Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naga wgsl-in allows vecN<bool> && vecN<bool> (with 2 &s) but Chromium/dawn doesn't #6856

Open
expenses opened this issue Jan 4, 2025 · 1 comment
Open

Naga wgsl-in allows vecN<bool> && vecN<bool> (with 2 &s) but Chromium/dawn doesn't #6856

expenses opened this issue Jan 4, 2025 · 1 comment
Labels
area: naga front-end lang: WGSL WebGPU Shading Language naga Shader Translator type: bug Something isn't working

Comments

@expenses
Copy link
Contributor

expenses commented Jan 4, 2025

This code worked fine in naga/wgpu but broke in dawn:
image

vecN<bool> & vecN<bool> works fine everywhere. I'm not sure if this is a naga issue, a wgsl issue or a specification issue.
@sagudev
Copy link
Contributor

sagudev commented Jan 4, 2025 •
edited
Loading

This is not allowed per spec: https://www.w3.org/TR/WGSL/#logical-expr, same also applies for logical or. Relevant code is here:

wgpu/naga/src/proc/constant_evaluator.rs

Line 2054 in 959c2db

| BinaryOperator::LogicalAnd

@expenses expenses mentioned this issue Jan 5, 2025
Open
@teoxoy teoxoy added type: bug Something isn't working naga Shader Translator area: naga front-end lang: WGSL WebGPU Shading Language labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: naga front-end lang: WGSL WebGPU Shading Language naga Shader Translator type: bug Something isn't working
Projects
WebGPU for Firefox
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@expenses @sagudev @teoxoy