Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the android-arm64 architecture #49

Open
gounthar opened this issue Dec 16, 2024 · 8 comments · May be fixed by #63
Open

Add support for the android-arm64 architecture #49

gounthar opened this issue Dec 16, 2024 · 8 comments · May be fixed by #63
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gounthar
Copy link

This extension does not support the android-arm64 architecture. I tried to install it on a android-arm64 machine, and it failed due to the lack of an available binary. Would you be able to update the extension's build and release process to include the relevant binary? For more details, see https://docs.github.com/en/github-cli/github-cli/creating-github-cli-extensions.

@chrisreddington
Copy link
Collaborator

Thanks @gounthar - I'll mark this as a good issue for someone to look into 😄 Appreciate you raising the request here!

@chrisreddington chrisreddington added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 28, 2024
@chrisreddington chrisreddington moved this from Needs Review to Ready to Start in gh-skyline Dec 28, 2024
@gounthar
Copy link
Author

Thanks a lot 🙏

@siddharthkoli
Copy link
Contributor

Hi @chrisreddington, I'd love to work on this!

@siddharthkoli
Copy link
Contributor

Hi @gounthar @chrisreddington, I've compiled a binary for android-arm64 and I'd really appreciate some help with this:

image

Seems like a dns lookup failed, but I can curl the same urls with my token using gh auth token and get back a response.
I've tried both https and ssh protocols.
I'm running this using termux, and I'm authenticated with gh cli.

Any ideas?

@eggplants
Copy link

@eggplants eggplants linked a pull request Jan 5, 2025 that will close this issue
@chrisreddington
Copy link
Collaborator

Hey @siddharthkoli - It looks like @eggplants has raised a PR targeting this as well. From the screenshots in that PR, it looks like it works as expected, so might be an issue with your local compilation?

I'll review @eggplants' PR soon, and look to get another release out.

@siddharthkoli
Copy link
Contributor

Sure, no problem!

1 similar comment
@siddharthkoli
Copy link
Contributor

Sure, no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Ready to Start
Development

Successfully merging a pull request may close this issue.

4 participants