-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer to attempt again with conflicting deps unlocked when version resolution fails #3622
Comments
What were you thinking for CI-related env vars |
We can research what the popular CI platforms set. |
One more thing, sry for spam, does "offer to unlock" packages involve some sort of cli action where user says like yes/no to update their gleam.toml, if so is there an example of another command setting up a series of cli fns in this way? Ty |
I think we'd print the error, and then something like
|
Can you explain a bit more a case where this flow is triggered? I originally misunderstood "locked" a bit. Would this occur during |
Any time when resolution fails and the packages responsible for the failure are in the manifest, meaning they are locked |
Got this working for the main case where an incompatibility is caused due to a locked file. Would you also like this CI action to handle this case as well?
This happens when the manifest's locked version isn't within |
Sorry, not sure what you mean by CI action. Could you expand on that?
I think this may be a bug where a version isn't getting unlocked when the constraint specified in |
Meant CLI action, being pausing the flow of the CLI to wait for the user to respond y/n to automatically unlocking. And ok interesting, I'll look more into it |
Marked linked pr as ready |
If you add a new dep it can fail due to conflicts with already locked versions of other deps.
I don't know how effective this might be, but I think we could do this:
If we are on CI (we can look for CI related environment variables) do not offer this functionality.
The text was updated successfully, but these errors were encountered: