We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I just walked through the code and the cache init routine is a bit confusing. The part I'm referencing enhancing with the context is the InitFunc: tegola/cache/cache.go Line 136 in 93b917e type InitFunc func(dict.Dicter) (Interface, error) This is called by the For method: tegola/cache/cache.go Line 165 in 93b917e func For(cacheType string, config dict.Dicter) (Interface, error) { Which is invoked by the internal cmd/internal/register/ package: tegola/cmd/internal/register/caches.go Line 16 in 93b917e func Cache(config dict.Dicter) (cache.Interface, error) { The main value we would get with this plumbing is if tegola is started up and then killed before the cache initializes fully. I'm not going to block the PR on this request, but just following up on the intent of my comment. Your call if you want to make this change ;-) Originally posted by @ARolek in #1013 (comment)
I just walked through the code and the cache init routine is a bit confusing. The part I'm referencing enhancing with the context is the InitFunc:
tegola/cache/cache.go
Line 136 in 93b917e
This is called by the For method:
For
Line 165 in 93b917e
Which is invoked by the internal cmd/internal/register/ package:
cmd/internal/register/
tegola/cmd/internal/register/caches.go
Line 16 in 93b917e
The main value we would get with this plumbing is if tegola is started up and then killed before the cache initializes fully.
I'm not going to block the PR on this request, but just following up on the intent of my comment. Your call if you want to make this change ;-)
Originally posted by @ARolek in #1013 (comment)
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The text was updated successfully, but these errors were encountered: