Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: add author to issue notification comments #26816

Open
josharian opened this issue Aug 5, 2018 · 4 comments · May be fixed by golang/build#10 or golang/build#20
Open

x/build/cmd/gopherbot: add author to issue notification comments #26816

josharian opened this issue Aug 5, 2018 · 4 comments · May be fixed by golang/build#10 or golang/build#20
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal. help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@josharian
Copy link
Contributor

josharian commented Aug 5, 2018 •
edited
Loading

gopherbot generates the "CL mentions this issue" issue comments:

https://github.com/golang/build/blob/4639cd3919e4243a672a11a56543004bf1778326/cmd/gopherbot/gopherbot.go#L811

It currently includes a link to the CL and the CL title. It'd be nice if it also included the CL author's name or handle. Maybe: "Change <link> by <author> mentions this issue: <title>".
@gopherbot gopherbot added this to the Unreleased milestone Aug 5, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 5, 2018
@FiloSottile FiloSottile added NeedsFix The path to resolution is known, but the work has not been done. FeatureRequest Issues asking for a new feature that does not need a proposal. labels Aug 6, 2018
@kzisme kzisme linked a pull request Aug 6, 2018 that will close this issue
Open
@iamoryanmoshe
Copy link
Contributor

I'll take a crack at it

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/127930 mentions this issue: cmd/gopherbot: change issue notification comment to include author name

@iamoryanmoshe
Copy link
Contributor

Or not

@codebien codebien linked a pull request Jun 12, 2019 that will close this issue
Open
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/181977 mentions this issue: cmd/gopherbot: add the author of the change to the notification on github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest Issues asking for a new feature that does not need a proposal. help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
4 participants
@josharian @FiloSottile @gopherbot @iamoryanmoshe