x/pkgsite/devtools/cmd/seeddb: trim spaces from version list

[jeanbza]

What is the URL of the page with the issue?

https://artifacts.netflix.net/api/go/goproxy (private jfrog artifactory go module proxy)

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36

Screenshot

No response

What did you do?

GO_MODULE_PROXY_URL=https://artifacts.netflix.net/api/go/goproxy \
    go run devtools/cmd/seeddb/main.go -keep_going=true

What did you see happen?

seeddb: Info: Error executing fetch: proxy.Client.Info("github.netflix.net/example.com/foo", "v1.65.0 "): Client.readBody("github.netflix.net/corp/ftl-proxy", "v1.65.0 ", "info"): executeRequest(ctx, "https://artifacts.netflix.net/api/go/goproxy/github.netflix.net/example.com/foo/@v/v1.65.0 .info"): "{\n  \"errors\" : [ {\n    \"status\" : 404,\n    \"message\" : \"Could not find resource\"\n  } ]\n}": not found (code 404)

What did you expect to see?

seeddb (and co) should strip the space suffix.

---

Explanation: jFrog Artifactory returns an extra space after versions

The response returned from a version list query contains an extra space after the versions. Ex https://artifacts.netflix.net/api/go/goproxy/github.netflix.net/example.com/foo/@v/list return v0.0.7 not v0.0.7.

The golang proxy, in contrast, does not do that. Ex https://proxy.golang.org/github.com/googleforgames/agones/@v/list returns v1.9.0 (no trailing space).

This breaks a pkgsite assumption. It takes those versions and constructs a path with a .info suffix to download things like https://artifacts.netflix.net/api/go/goproxy/github.netflix.net/example.com/foo/@v/v0.0.7.info. But since there's a space, that url actually becomes https://artifacts.netflix.net/api/go/goproxy/github.netflix.net/example.com/foo/@v/v0.0.7 .info which is malformed.

[jeanbza]

Fix at https://go-review.googlesource.com/c/pkgsite/+/640655

[seankhliao]

Shouldn't this be an Artifactory bug for returning extraneous output?

[gabyhelp]

Related Issues

• x/pkgsite: seeddb -keep_going through version list errors #71140

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/640655 mentions this issue: internal/proxy: clean versions returned with spaces