Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal-x86_64: actually have spinlocks disable IRQs #500

Open
hawkw opened this issue Jan 1, 2025 · 0 comments
Open

hal-x86_64: actually have spinlocks disable IRQs #500

hawkw opened this issue Jan 1, 2025 · 0 comments
Labels
arch/x86 arch/x86_64 area/hal Related to the hardware abstraction layer kind/enhancement New feature or request

Comments

@hawkw
Copy link
Owner

hawkw commented Jan 1, 2025

now that #188 / #486 are done, we could actually use mutex critical sections in the x86 kernel. this would prevent of the tracing-in-ISRs deadlock rakes i've stupidly gone out of my way to step on.

disabling all IRQs in a critical section is not ideal. we could probably pick and choose a bit. but this is probably better than not doing it. if spin_lock_irqsave is good enough for linux, it's good enough for us.

@hawkw hawkw added kind/enhancement New feature or request area/hal Related to the hardware abstraction layer arch/x86 arch/x86_64 labels Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch/x86 arch/x86_64 area/hal Related to the hardware abstraction layer kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant