Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial references a now missing /health endpoint #79

Open
timsneath opened this issue Dec 16, 2024 · 0 comments
Open

Tutorial references a now missing /health endpoint #79

timsneath opened this issue Dec 16, 2024 · 0 comments

Comments

@timsneath
Copy link

In the tutorial, there's a reference to a /health endpoint that is created in the buildRouter() method:

Here we create the `Router`. We add a logging middleware to it (this logs all requests to the router). The function uses a result builder to create a stack of middleware, but you can also use `Router.add(middleware:)` to add individual middleware. Finally we add a single endpoint GET `/health` which returns a 200 (Ok) response.

However, the current template instead just creates a root endpoint:

https://github.com/hummingbird-project/template/blob/13e946207648d27f8b4c4091f4030d5a6a9e63be/Sources/App/Application%2Bbuild.swift#L41-L54

Accordingly, the tutorial should be updated to remove references to the /health endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant