Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For login via browser do not use logging to show login code #2793

Open
mfriedenhagen opened this issue Dec 17, 2024 · 0 comments
Open

For login via browser do not use logging to show login code #2793

mfriedenhagen opened this issue Dec 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mfriedenhagen
Copy link

Describe the bug

  • Our internal Artifactory server provides SSO since some days.
  • Now I tried to login with the web-method for the first time, before I created identity token manually resp. used basic auth.
  • In Artifactory I was asked for a verification code given by the client.
  • However, it was not shown.
  • As I yesterday helped a new colleague with setting up jf I knew that this works in general
  • After giving it some thought I remembered that I (intentionally) always set JFROG_CLI_LOG_LEVEL=ERROR in my .zshrc because I generally do not need the info output.
  • When running JFROG_CLI_LOG_LEVEL=info jf login I succeeded.
  • At least I consider the verification code output as something which should not use the log-output but just stdout.

Current behavior

Verification code for web-login is logged with level info.

Reproduction steps

Run JFROG_CLI_LOG_LEVEL=ERROR jf login and choose web-login.

Expected behavior

I expect the verification code for web-login to just be printed to stdout

JFrog CLI version

2.72.2

Operating system type and version

macOS 15.1.1 (24B91)

JFrog Artifactory version

7.98.9

JFrog Xray version

??

@mfriedenhagen mfriedenhagen added the bug Something isn't working label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant