Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-arch container builds are having some trouble #321

Open
shaneutt opened this issue Dec 9, 2024 · 3 comments
Open

Multi-arch container builds are having some trouble #321

shaneutt opened this issue Dec 9, 2024 · 3 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@shaneutt
Copy link
Member

shaneutt commented Dec 9, 2024

We recently updated our multi-arch container build, and since then I've seen quite a few failures that appear may be flakes and on success, I've seen it take as long as 70 minutes.

This isn't tenable to run on every PR, and each update for that PR. We need to evaluate a different strategy for container builds. Perhaps we can do the full multi-arch build on releases, but for PRs only do a basic x86_64 build?

The purpose of this issue is to explore a bit and see what potential solutions there are, pick one and implement it.

@shaneutt shaneutt added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Dec 9, 2024
@shaneutt shaneutt added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 9, 2024
@shaneutt shaneutt moved this to Next in Blixt Project Board Dec 9, 2024
@jokestax
Copy link
Contributor

jokestax commented Dec 22, 2024

Hey @shaneutt, could I take this up? I’ve been experimenting with matrix builds and exploring this (https://github.com/taiki-e/upload-rust-binary-action)] I’ll raise a PR with my implementation by this week.

@aryan9600
Copy link
Member

the point of doing multi-arch builds for PRs is to verify that we aren't breaking compatibility with arm or x86. since our project relies on quite a bit of third party deps and libraries, its relatively easy to make a change that breaks on a platform.
one thing we can do to speed up CI for PRs, is to split the build into two different jobs, one for each arch. we would build the image for each architecture, but do so natively and in parallel.

we can do a proper multi arch build for releases.

@shaneutt
Copy link
Member Author

shaneutt commented Jan 6, 2025

@jokestax it would be great if you want to take a look at this, thank you!

/assign @jokestax

Keep in mind what @aryan9600 has said above and confer with him going forward. Particularly:

we can do a proper multi arch build for releases.

I do think we should probably only run these tests (only) on releases.

If this ends up getting very difficult or nebulous for some reason though, please check back in here and we'll support you.

@shaneutt shaneutt removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 6, 2025
@shaneutt shaneutt moved this from Next to In Progress in Blixt Project Board Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
Status: In Progress
Development

No branches or pull requests

3 participants