Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Clicking on Update Notification should open main GUI #211

Open
sohang3112 opened this issue Jan 28, 2023 · 4 comments
Open

Comments

@sohang3112
Copy link

When the update notification appears, then clicking it should open the main GUI so that the packages can be updated.

@anaselli
Copy link
Collaborator

we use pystray to implement notification icon. Official documentation is here, any help to improve our work is welcome :)

@sohang3112
Copy link
Author

In this section of the pystray docs, the following is mentioned:

In order to receive notifications about user interaction with the icon, a popup menu can be added with the menu constructor argument.

This must be an instance of pystray.Menu. Please see the reference for more information about the format.

It will be displayed when the right-hand button has been pressed on the icon on Windows, and when the icon has been clicked on other platforms. Menus are not supported on X.

So what I mentioned should be possible to do with pystray.Menu - however I'm not sure if Wayland is supported or not (they have explicitly mentioned that X is NOT supported).

@anaselli
Copy link
Collaborator

Updater is here. I used some different DMs on a virtual machine to make my tests. I'm not the original developer for this feature so if you have the time to make some test for this request and a PR eventually, i will glad to make a new dnfdragora release after :) thanks for your help

@sohang3112
Copy link
Author

@anaselli I experimented with the code yesterday - unfortunately pystray doesn't support clickable notifications right now 😔. In this pystray feature request for clickable notifications, the pystray repo owner said clickable notifications might not be possible on some platforms.

Looks like the only way to do this would be to try directly with Gtk / Qt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants