Arg parsing fails if URL ends with ]

[MattIPv4]

autocannon http://localhost\?id=\[1\] results in the help message being shown (if you log argv, it seems that the URL [missing the closing ]] is buried in argv._[0]._[0]).

autocannon http://localhost\?id=\[1\]\&other works as expected though (and logging argv shows that the URL is at argv._[0] as the code expects.

[mcollina]

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

[MattIPv4]

I dig a very small bit of digging into this, and it looks to be a bug in subarg I think. I cannot find a repository on GitHub for that package, it doesn't appear to be maintained. As such, I imagine this'll be quite a big chunk of work to find a replacement package for arg parsing that behaves in the same way.

[GlenTiki]

Hey @MattIPv4, The author of that module has basically removed their social media presence, including their GitHub, but there’s people who have gotten access to origin control for some of his repos/modules, specifically minimist, a popular cli parsing library that subarg was built to be used with. I’ve reached out here, and got a reply they’ll try get access to that repo - https://twitter.com/ljharb/status/1780589808382800279

This’ll allow us to upstream that fix without needing to create a successor fork.

[MattIPv4]

👀 That tweet link doesn't go anywhere, but sounds good. And to confirm, you meant getting access to subarg, not minimist?

[GlenTiki]

My bad, deleted a few chars at the end! 😅 Its fixed now, fyi.

And yes, we're looking for subarg access to fix there.

[ljharb]

Give me a few days to a week (or two), and I’ll either have the original package name and repo, or I’ll make a fork.

[ljharb]

Unfortunately Github/npm weren't wiling or able to help, so I'll have to recover the repo myself and make a fork. I'll comment here once that's done.

[mcollina]

Thanks

[ljharb]

https://github.com/minimistjs/subarg is now recovered, and i published the 3 original versions as @minimistjs/subarg.

I did not make any changes on these 3 publishes besides the package name, so the repo URL will still be incorrect.

I intend to publish a v1.0.1 after updating CI and other things, which will have the correct URLs, but in the meantime, you can do a drop-in replacement of subarg to @minimistjs/subarg, and you'll get a Tidelift-lifted, actually maintained package.

[mcollina]

@MattIPv4 @GlenTiki a PR would be really nice to fix this.

[ljharb]

#524 replaces the dep; i'd love a detailed issue and/or PR in subarg about the underlying problem for this issue :-)

[mcollina]

ping @GlenTiki @MattIPv4

[GlenTiki]

I plan on picking this up btw if @MattIPv4 doesnt get a chance. I’m on vacation atm so sorry for the late response.

[MattIPv4]

Go for it, I've been super busy w/ work et al. Sorry!

[GlenTiki]

Just back from vacation, will self assign this.

[ljharb]

reminder ping