[BUG] Non-text elements lack sufficient colour contrast. #1758
Labels
Comments
microsoft-github-policy-service
bot
added
the
status: new
5 tasks
DaveTryon
added a commit
that referenced
this issue
Jan 19, 2024
#### Details As called out in #1758, the search box doesn't meet non-text color contrast requirements. This PR changes the border so that it's consistently displayed in all themes. ##### Motivation Address #1758 ##### Screenshots Mode | Before (only dark mode has border) | After (all modes have border) --- | --- | --- Light |  |  Dark |  |  Aquatic |  |  Desert |  |  Dusk |  |  Night Sky |  |  ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> Since the `SearchPanelBorderThickness` value is now always 1, I replaced the variable (originally added for dark mode) with a hardcoded value <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Run through of all [test scenarios](https://github.com/Microsoft/accessibility-insights-windows/blob/main/docs/Scenarios.md) completed? - [x] Does this address an existing issue? If yes, Issue# - 1758 - [x] Includes UI changes? - [x] Run the production version of Accessibility Insights for Windows against a version with changes. - [x] Attach any screenshots / GIF's that are applicable. > Note: After the PR has been created, certain checks will be kicked off. All of these checks must pass before a merge.
|
This is live in Canary and will be included in our next Production release |
DaveTryon
added
status: resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(This is split out from #1738)
From @delphinegilbert:
Hello,
An accessibility audit was performed on Accessibility Insights for Windows in our department and the following issue was found:
Description of issue
Right under "Live Inspect", there is a search input field that lacks any kind of visible border which makes it difficult to see. The input field's colour contrast fails against the white background.
Impact on users
This will especially impact people with low vision and non-keyboard, as users may not see at all that they the input field is there.
Steps to reproduce
Launch the program, and dismiss the startup windows. Using your mouse, hover or click on any other window for the program to start inspecting. It should then display an item tree, there there's a search field at the top.
The text was updated successfully, but these errors were encountered: