Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening "elevate-shim.exe" causes Computer to glitch #18058

Closed
ghost opened this issue Oct 15, 2024 · 10 comments
Closed

Opening "elevate-shim.exe" causes Computer to glitch #18058

ghost opened this issue Oct 15, 2024 · 10 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@ghost
Copy link

ghost commented Oct 15, 2024

Windows Terminal version

1.21.2701.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

It looks like a regression, this bug has been reported before in #16009

  1. In Windows Explorer, double-click on "elevate-shim.exe".
  2. In the UAC prompt window, click "Yes" to grant permissions.

Expected Behavior

No response

Actual Behavior

Same as #16009

@ghost ghost added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 15, 2024
@ghost ghost changed the title Opening "elevate-shim.exe" causes System to glitch Opening "elevate-shim.exe" causes Computer to glitch Oct 15, 2024
@DHowett
Copy link
Member

DHowett commented Oct 15, 2024

Thanks for filing!

As a note, elevate-shim is an implementation detail. It is not intended to be run directly.

@Zeroes1
Copy link

Zeroes1 commented Oct 15, 2024

@DHowett If a person accidentally launched it, then now he should suffer? :)

@DHowett
Copy link
Member

DHowett commented Oct 15, 2024

Yyyyes? People who launch random EXE files with reckless abandon can learn not to do so! 😁

@lhecker
Copy link
Member

lhecker commented Oct 15, 2024

I suspect this was fixed by #15327 because it fixed the argument passing.

@Zeroes1
Copy link

Zeroes1 commented Oct 16, 2024

@DHowett @lhecker

As a note, elevate-shim is an implementation detail. It is not intended to be run directly.

Why not use a file without the EXE extension for this? for example elevate-shim.run ?
You run elevate-shim with CreateProcessW (no need EXE extension for start process)

@Zeroes1
Copy link

Zeroes1 commented Oct 16, 2024

@lhecker

TEST:
if user manually run elevate-shim.exe

terminal-1.21.2701.0 [latest release] - problem
terminal-1.22.2702.0 [latest preview] - no problem
terminal-1.23.2891.0 [latest canary] - no problem

in next version release will be OK?

@lhecker
Copy link
Member

lhecker commented Oct 16, 2024

Yeah, sounds like it was fixed in that PR then. Thanks for testing this!

Why not use a file without the EXE extension for this? for example elevate-shim.run ?

If this issue comes up more often in the future we could explore that idea. 🙂

@lhecker lhecker closed this as completed Oct 16, 2024
@Sinazrp
Copy link

Sinazrp commented Jan 5, 2025

I have same problem and I am in middle of installing something important

@zadjii-msft
Copy link
Member

A question: why are you directly running elevate-shim? It is an internal helper tool. There's literally no reason to run that yourself directly, right?

@Sinazrp
Copy link

Sinazrp commented Jan 6, 2025

Why would a Microsoft-produced application include an executable file that behaves in a way similar to a virus? Why is there an unnecessary .exe file included? I don’t randomly click on executable files, but this is a Microsoft product—I thought we could trust Microsoft. Why is the responsibility being shifted to users instead of addressing this by modifying or removing that .exe file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

5 participants