Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DynamicData source to be on base types #4482

Merged
merged 8 commits into from
Jan 4, 2025
Merged

Allow DynamicData source to be on base types #4482

merged 8 commits into from
Jan 4, 2025

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Dec 31, 2024 •
edited
Loading

Fixes #4347

@Youssef1313 Youssef1313 marked this pull request as ready for review December 31, 2024 18:44
Evangelink
Evangelink approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One TODO to drop or fix but other LGTM

src/Adapter/MSTest.TestAdapter/Execution/TypeCache.cs Show resolved Hide resolved
@Evangelink Evangelink mentioned this pull request Jan 4, 2025
Open
@Evangelink Evangelink merged commit 5f134f5 into microsoft:main Jan 4, 2025
11 checks passed
@Youssef1313 Youssef1313 deleted the dynamicdata-allow-inherited-lookup branch January 4, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
Area: Parameterized tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not require member type in [DynamicData] when member is defined on base class
2 participants
@Youssef1313 @Evangelink