Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure MSTest.SourceGeneration is updated for DynamicData Autodetect mode #4369

Closed
Youssef1313 opened this issue Dec 17, 2024 · 6 comments
Closed
Assignees

Comments

@Youssef1313
Copy link
Member

NativeAotTests_WillRunWithExitCodeZero will be skipped temporarily in #4340

@Youssef1313 Youssef1313 added this to the MSTest 3.8 / Platform 1.6 milestone Dec 17, 2024
@Youssef1313 Youssef1313 self-assigned this Dec 18, 2024
@Youssef1313
Copy link
Member Author

Re-opening. This if fixed in https://github.com/microsoft/testanywhere/pull/2492, but we need an updated version of MSTest.SourceGeneration to unskip the test.

@Youssef1313 Youssef1313 reopened this Dec 18, 2024
@Youssef1313
Copy link
Member Author

The test is now unskipped, but we still need to publish updated package to NuGet.org.

@Evangelink
Copy link
Member

Do we? We are using packages from the test-tools feed.

@Youssef1313
Copy link
Member Author

@Evangelink But we need something for end users to be able to use?

@Evangelink
Copy link
Member

Yes when we will push publicly 3.8 preview or release stable 3.8. Or am I missing something you are thinking about?

@Youssef1313
Copy link
Member Author

Yup. The milestone is set to 3.8. This is probably going to just be fixed on its own by the normal release procedure anyways. Fine for me if you want to close.

There is #4443 for 3.7 though but that's irrelevant to the DynamicData support we did on the source gen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants