Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExpectedException codefix should be updated to handle the recent changes to Assert.Throws* overloads #4491

Closed
Youssef1313 opened this issue Jan 1, 2025 · 0 comments · Fixed by #4504
Closed

ExpectedException codefix should be updated to handle the recent changes to Assert.Throws* overloads #4491

Youssef1313 opened this issue Jan 1, 2025 · 0 comments · Fixed by #4504
Assignees
@Youssef1313
Labels
Area: Analyzers In-PR sprint

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jan 1, 2025 •
edited by pavelhorak
Loading

Describe the bug

  • The fixer used to only handle the case when AllowDerivedTypes is false. But now that we have Assert.Throws and Assert.ThrowsExactly (and the async variants), it should be possible for the fixer to handle when AllowDerivedTypes is true.
  • The fixer is currently switching to the non-recommended methods. It should be updated to use the new ones.

AB#2331940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
Area: Analyzers In-PR sprint
Projects
None yet
Milestone
No milestone
1 participant
@Youssef1313