Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix Visual Studio 2022 support #81

Open
Neutrino-Sunset opened this issue Dec 28, 2024 · 2 comments
Open

Please fix Visual Studio 2022 support #81

Neutrino-Sunset opened this issue Dec 28, 2024 · 2 comments

Comments

@Neutrino-Sunset
Copy link

Neutrino-Sunset commented Dec 28, 2024

This issue and this issue demonstrate how this extension does not work in Visual Studio 2022.

There are multiple problems.

Firstly, the versions of Typescript and the Angular Language Service that the extension is bundled with are massively out-of-date and not compatible with the Angular version that is used in a project created using the Visual Studio Angular project template.

The second problem is that the versions of these libraries used by a project is ignored in favour of the bundled out-of-date version. This is true at least in the case where the Project directory is a descendent of the Solution directory, which is the default and the only viable option in any non-trivial application.

The last problem is that currently with this extension installed opening any component file causes Visual Studio to freeze for about 10 seconds. It does this every single time I open a component file.

The fact that the language service does not work makes it virtually pointless having a Visual Studio Angular project template at all.

With the tooling in this state can anyone really be expected to recommend this workflow to their development teams?

Our Visual Studio licences cost us a huge amount of money. I expect a better return on that investment than this.

@Khyalis
Copy link

Khyalis commented Dec 30, 2024

#80 looks quite promising, although trying to keep up with updates for angular / vscode-ng-language-service may be an ongoing commitment.

Maybe changing the probing to also support nested angular projects might be reasonable, too, although I suspect supporting the case of multiple projects within the same solution may not be straight forward.
I think the vscode extension would default to using the lowest angular version detected if it finds multiple versions within the same workspace, but using mismatched angular and language-service versions for some of the projects may not be ideal.

@Khyalis
Copy link

Khyalis commented Jan 1, 2025

Apart from aforementioned issues #76 and #78, issue #73 also might find its cause

  • in bundling a not quite recent version of @angular/language-server (and typescript) that lacks support for current angular versions / features or
  • the documentation being not very clear about how override the bundled versions or
  • the mechanism for overriding the bundled versions being not an optimal match for a commonly used solution folder structure of using sub-folders nested within the solution folder for solution projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants